Opened 4 years ago

Closed 3 years ago

#2844 closed enhancement (fixed)

make c['www']['url'] mandatory

Reported by: dustin Owned by: dustin
Priority: major Milestone: 0.9.0
Version: 0.8.9 Keywords: simple
Cc:

Change History (10)

comment:1 Changed 3 years ago by ewong

  • Owner set to ewong
  • Status changed from new to assigned

comment:2 Changed 3 years ago by ewong

re: https://github.com/buildbot/buildbot/pull/1247#issuecomment-59825479

So I'm adjusting this ticket to:

make c['www']['url'] mandatory, with no default at all.

Last edited 3 years ago by sa2ajj (previous) (diff)

comment:3 Changed 3 years ago by ewong

  • Summary changed from c['www']['url'] should default to c['buildbotURL'] to make c['www']['url'] mandatory

comment:4 Changed 3 years ago by ewong

  • Owner changed from ewong to dustin

comment:5 Changed 3 years ago by dustin

From that pull req: --- The Status class will be dead before 0.9.0 is released, so it doesn't matter.

Yes, this is about compatibility, to help users who are migrating their configuration.

There's an argument to be made that, since the c['www'] section must be added in 0.9.0, users should add c['www']['url'] there and we don't need a fallback. We could just make it mandatory -- that would save others from the error I made here, which is what made me file the bug that begat this pull request.

So let's do that: make c['www']['url'] mandatory, with no default at all.

Last edited 3 years ago by sa2ajj (previous) (diff)

comment:7 Changed 3 years ago by dustin

Yes, and BuildStatus and BuildSlaveStatus and BuilderStatus and all the other BS :)

comment:8 Changed 3 years ago by dustin

I need to revisit this -- if c['www'] isn't provided, will the whole web package (API and UI) not be loaded? If so, then forcing users to configure c['www']['url'] will force them to run the web package on every master.

comment:9 Changed 3 years ago by Mikhail Sobolev <mss@…>

In 637f265a00ddce2cd695b33f1022748a10890841:

Merge pull request #1407 from djmitche/bug2844

Remove c['www']['url'], keepign the existing c['buildbotURL']

comment:10 Changed 3 years ago by dustin

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.