git tests fail if user's git prefs aren't set

[dustin]

    *** Your name cannot be determined from your system services (gecos).
    
    Run 
    
      git config --global user.email "you@email.com"
      git config --global user.name "Your Name"
    
    to set your account's default identity.
    Omit --global to set the identity only in this repository.
    
    fatal: empty ident  <foo@bar.r.igoro.us> not allowed
}}]

I think just running 'git config' with some reasonable defaults would fix this.

[dustin]

fix for username issue (#281:make-user-info.patch)

[dustin]

I still get

===============================================================================
[FAIL]: buildbot.test.test_vc.Git.testCheckout

Traceback (most recent call last):
  File "/home/dev/devel/projects/buildbot/t/dustin/buildbot/test/test_vc.py", line 544, in _do_vctest_clobber_1
    self.failUnlessEqual(bs.getProperty("revision"), '')
twisted.trial.unittest.FailTest: None != ''
===============================================================================
[FAIL]: buildbot.test.test_vc.Git.testPatch

Traceback (most recent call last):
  File "/home/dev/devel/projects/buildbot/t/dustin/buildbot/test/test_vc.py", line 761, in _doPatch_2
    self.failUnlessEqual(bs.getProperty("revision"), '')
twisted.trial.unittest.FailTest: None != ''
===============================================================================
[ERROR]: buildbot.test.test_vc.Git.testTry

Traceback (most recent call last):
  File "/usr/lib64/python2.4/site-packages/twisted/internet/defer.py", line 576, in _deferGenerator
    result = g.next()
  File "/home/dev/devel/projects/buildbot/t/dustin/buildbot/test/test_vc.py", line 2606, in vc_revise
    yield w; w.getResult()
  File "/usr/lib64/python2.4/site-packages/twisted/internet/defer.py", line 555, in getResult
    self.result.raiseException()
  File "/usr/lib64/python2.4/site-packages/twisted/internet/defer.py", line 317, in _runCallbacks
    self.result = callback(self.result, *args, **kw)
  File "/home/dev/devel/projects/buildbot/t/dustin/buildbot/test/test_vc.py", line 343, in check
    raise RuntimeError("command %s finished with exit code %d"
exceptions.RuntimeError: command ['/usr/bin/git', 'commit', '-m', 'revised_to_2', 'version.c'] finished with exit code 128: see logs for stdout
-------------------------------------------------------------------------------

Are the first two known errors? The last is a similar problem to what 281.patch solves, but I haven't tracked it down yet.

[dustin]

Oy, the first two are my fault. Who tests this stuff anyway? Me? Oh.

[dustin]

in the dev repo as #281:fix-vc-tests.patch

[dustin]

in brian's tree