Opened 5 years ago

Closed 5 years ago

#2756 closed defect (fixed)

latest master from git has error on reconfig: "MailNotifier instance has no attribute '_buildSetSubscription'"

Reported by: dank Owned by:
Priority: critical Milestone: 0.8.9
Version: master Keywords:
Cc:

Description (last modified by dustin)

Doing a reconfig with the latest 0.8.8+ from git fails for me with

        File "master/buildbot/status/buildset.py", line 81, in summaryUnsubscribe
            if self._buildSetSubscription is not None:
        exceptions.AttributeError: MailNotifier instance has no attribute '_buildSetSubscription'

2014-04-14 12:45:25-0700 [-] WARNING: reconfig partially applied; master may malfunction

The offending line was introduced recently, by

commit 3d6609a6079a23ef5d730eaf731f7b0f116222e2
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Sat Oct 5 23:27:24 2013 -0500

    GerritStatusPush: Add per-buildset status updates

so this may be a regression.

Change History (2)

comment:1 Changed 5 years ago by dustin

  • Description modified (diff)
  • Keywords regression removed
  • Priority changed from major to critical

comment:2 Changed 5 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed
commit cf4c10c2372db16290c2bd1ab86d4a14227d5f13
Author: Dustin J. Mitchell <dustin@buildbot.net>
Date:   Mon Apr 14 18:10:12 2014 -0400

    ensure that summaryUnsubscribe succeeds

    `summaryUnsubscribe` shoud be callable even if `summarySubscribe` hasn't
    been called.  Fixes #2756.
Note: See TracTickets for help on using tickets.