Opened 6 years ago

Closed 6 years ago

#2683 closed defect (fixed)

clobber if git clean fails

Reported by: dustin Owned by:
Priority: major Milestone: 0.8.9
Version: 0.8.8 Keywords: git
Cc:

Description

We've been seeing this on one of the metabuildbot buildslaves for quite a while now:

 (view as text)

git --version
 in dir /usr/home/buildbot/buildbot/py27-sa068/build (timeout 1200 secs)
 watching logfiles {}
 argv: ['git', '--version']
 environment:
  BLOCKSIZE=K
  EDITOR=vi
  ENV=/home/buildbot/.shrc
  HOME=/home/buildbot
  LOGNAME=buildbot
  MAIL=/var/mail/buildbot
  PAGER=more
  PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/home/buildbot/bin
  PWD=/usr/home/buildbot/buildbot/py27-sa068/build
  SHELL=/bin/sh
  SUDO_COMMAND=/bin/sh -c buildslave restart buildbot
  SUDO_GID=1001
  SUDO_UID=1001
  SUDO_USER=koobs
  TERM=xterm
  USER=buildbot
  USERNAME=buildbot
 using PTY: False
git version 1.8.5.2
program finished with exit code 0
elapsedTime=0.011283
program finished with exit code 1
program finished with exit code 0
git clean -f -d -x
 in dir /usr/home/buildbot/buildbot/py27-sa068/build (timeout 1200 secs)
 watching logfiles {}
 argv: ['git', 'clean', '-f', '-d', '-x']
 environment:
  BLOCKSIZE=K
  EDITOR=vi
  ENV=/home/buildbot/.shrc
  HOME=/home/buildbot
  LOGNAME=buildbot
  MAIL=/var/mail/buildbot
  PAGER=more
  PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/home/buildbot/bin
  PWD=/usr/home/buildbot/buildbot/py27-sa068/build
  SHELL=/bin/sh
  SUDO_COMMAND=/bin/sh -c buildslave restart buildbot
  SUDO_GID=1001
  SUDO_UID=1001
  SUDO_USER=koobs
  TERM=xterm
  USER=buildbot
  USERNAME=buildbot
 using PTY: False
fatal: Not a git repository (or any of the parent directories): .git
program finished with exit code 128
elapsedTime=0.009715

A directory listing shows that everything git would want is there in the .git directory, so I don't know what's wrong, but regardles, the right thing to do is rmdir build/ and start over.

Change History (1)

comment:1 Changed 6 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

We had a look at the contents of the directory, and it appears that one of the files in .git is empty (HEAD, IIRC), probably from a full disk at some point. Git refuses to go on after this, so every time the source step runs for this builder on this slave, it fails.

This was fixed in https://github.com/buildbot/buildbot/pull/1058

Note: See TracTickets for help on using tickets.