Opened 5 years ago

Closed 5 years ago

#2658 closed enhancement (fixed)

[nine] need to remove buildername from master/buildbot/data/buildrequests.py

Reported by: delanne Owned by: delanne
Priority: major Milestone: 0.9.0
Version: 0.8.8 Keywords:
Cc:

Description

The PR #1043 adds buildername as a data field for buildrequests.

It's a workaround, in order to make the PR easier.

The complication,is for callers that are switching from master.db.buildrequests.getBuildRequest to data.get and expecting a builder name.

buildername mustn't be exposed here. Users should be using builderid as the primary index for builders.

Change History (4)

comment:1 Changed 5 years ago by dustin

  • Type changed from undecided to enhancement

comment:2 Changed 5 years ago by delanne

  • Owner set to delanne
  • Status changed from new to accepted

comment:4 Changed 5 years ago by Mikhail Sobolev <sa2ajj@…>

  • Resolution set to fixed
  • Status changed from accepted to closed

In 2de3ca0b6b3eb923b6f1adf840bcb940f0ee66cd:

Merge pull request #1242 from delanne/trac2621_2658

PR for trac #2621 and trac #2658

Fixes ticket:2621
Fixes ticket:2658

Note: See TracTickets for help on using tickets.