Changes between Initial Version and Version 1 of Ticket #2633


Ignore:


Timestamp:
Feb 7, 2015, 9:06:25 PM (4 years ago)
Author:
dustin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2633

    • Property Priority changed from major to minor
    • Property Milestone changed from 0.9.0 to 0.9.+
    • Property Version changed from to master
    • Property Summary changed from [nine] Reduce Buildset Race Condition to Reduce Buildset Race Condition
  • Ticket #2633 – Description

    initial v1  
    1 Make `completeBuildSet` return true if the database claims to have updated the row, and use that to narrow the race condition in `maybeBuildsetComplete`
     1There's a race condition in `completeBuildset`: if two build requests finish at exactly the same time, on different masters, then both masters may run `completeBuildset` at the same time, see that the buildset is actually complete, and send a message indicating completion -- so, everyone will get two "completed" messages.
     2
     3Make `completeBuildset` return true if the database claims to have updated the row, and use that to narrow the race condition in `maybeBuildsetComplete`