Ticket #261 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

SVNPoller fails to recognise a branch deletion

Reported by: nhemingway Owned by: nhemingway
Priority: minor Milestone: 0.7.8
Version: 0.7.7 Keywords:
Cc: dustin

Description

If a SVN branch is deleted it is detected (correctly) as a change by SVNPoller. However, it then blindly creates a Change without taking into account the fact that the Change will attempt to checkout and build something that is no longer there.

Attachments

buildbot_branch_deletions.diff Download (5.0 KB) - added by nhemingway 5 years ago.
Patch to resolve #261

Change History

comment:1 Changed 5 years ago by nhemingway

  • Status changed from new to assigned

Changed 5 years ago by nhemingway

Patch to resolve #261

comment:2 Changed 5 years ago by nhemingway

  • Status changed from assigned to new

The patch I've just attached (buildbot_branch_deletions.diff) has svnpoller checking whether the change reported by SVN is a branch deletion. If it is, a buildbot Change is not created.

comment:3 Changed 5 years ago by dustin

  • Cc dustin added

I can't really see why someone would want buildbot to handle this sort of situation, but this does seem a better way to handle it.

In the dev tree as #261:buildbot_branch_deletions.diff

comment:4 Changed 5 years ago by nhemingway

The "standard" or "documented" use for buildbot is to build the same branch on multiple architectures. Our app is perl running in house on a single target platform. But we do have multiple project and ticket branches separate from trunk. So we use bb to have a builder perl branch. All fine until someone deletes their ticket branch (having merged it back to trunk) at which point bb fires off a (pointless) build for a branch that's no longer there!

comment:5 Changed 5 years ago by dustin

got it -- apparently I wasn't thinking too hard. Thanks!

comment:6 Changed 5 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed

pushed to brian's tree

comment:7 Changed 5 years ago by dustin

  • Milestone changed from undecided to 0.7.8
Note: See TracTickets for help on using tickets.