Opened 7 years ago

Closed 7 years ago

#2597 closed defect (fixed)

All pages should use the same "page built" date format

Reported by: shoelzer Owned by:
Priority: patches-accepted Milestone: 0.8.9
Version: 0.8.8 Keywords: web
Cc:

Description

Most pages use the same "page built" date format but the waterfall page is different.

On http://buildbot.buildbot.net/ the format is Tue 26 Nov 2013 22:57:22.

On http://buildbot.buildbot.net/waterfall the format is 26 Nov 2013.

All pages should use the same date format.

Also, oddly, my fresh install of Buildbot 0.8.8 has the wrong day on the waterfall page. It is one day behind: 25 Nov 2013. The computer is running Windows 7 and is set to the correct date and time. All other pages are correct.

Change History (3)

comment:1 Changed 7 years ago by dustin

  • Keywords web added
  • Milestone changed from undecided to 0.8.9
  • Priority changed from major to patches-accepted
  • Type changed from undecided to defect

Ah, it's because the time context element is being overwritten by the last date in the last line of waterfall.py.

Can you try out the patch in https://github.com/buildbot/buildbot/pull/986 and let me know if it hurts something else on the waterfall?

comment:2 Changed 7 years ago by shoelzer

That patch appears to fix the issue. The date is consistent and correct on all pages and the rest of the waterfall looks fine.

comment:3 Changed 7 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

Great, thanks!

Note: See TracTickets for help on using tickets.