Opened 5 years ago

Closed 5 years ago

#2596 closed defect (fixed)

Random problems with rss and atom feeds

Reported by: hwoarang Owned by:
Priority: major Milestone: 0.8.9
Version: 0.8.8 Keywords: web
Cc:

Description

Sometimes, the rss and/or atom feed is broken with errors like this


This page contains the following errors:

error on line 22 at column 51: error parsing attribute name Below is a rendering of the page up to the first error.

[....] Author list:


I am not sure what the root problem is and how to debug it. If you give me some pointers to debug it I can provide more information.

Change History (3)

comment:1 Changed 5 years ago by hwoarang

To clarify, the above output is from the /atom service

By looking the webpage source it appears that Authors are meant to be listed as

Name <email>

Could the <email> part confuse the xml and treats the <email> as an attribute?

comment:2 Changed 5 years ago by hwoarang

Modifying the

Author list: <b>{{ b.responsible_users|join(', ') }}</b><br/>

to be

Author list: <b>{{ b.responsible_users|join(', ')|e }}</b><br/>

in https://github.com/buildbot/buildbot/blob/master/master/buildbot/status/web/templates/feed_description.html

seems to fixes the problem because now the output is generated as

Name &lt;email&gt;

comment:3 Changed 5 years ago by dustin

  • Keywords web added
  • Milestone changed from undecided to 0.8.9
  • Resolution set to fixed
  • Status changed from new to closed
  • Type changed from undecided to defect
commit 50c900d2b03efcf7e5f195c4649b74a941f4210d
Author: Dustin J. Mitchell <dustin@mozilla.com>
Date:   Thu Nov 28 11:19:28 2013 -0500

    escape author names in feeds
    
    Fixes #2596
Note: See TracTickets for help on using tickets.