Opened 7 years ago

Closed 6 years ago

#2595 closed defect (fixed)

HgPoller splits file paths with spaces

Reported by: shoelzer Owned by:
Priority: major Milestone: 0.8.9
Version: 0.8.8 Keywords:
Cc:

Description

I'm using HgPoller? as a change source. When I look at a change detail page (something like /changes/15), file paths with spaces are listed as multiple files instead of single files in the "Changed files" list. For example, this:

path/to/repo/foo bar baz/hello.txt

ends up on three lines, like this:

bar
baz/hello.txt
path/to/repo/foo

Here's how I defined HgPoller?:

c['change_source'].append(HgPoller(
    repourl='http://path/to/repo/',
    branch='default',
    workdir='hgpoller-workdir',
    pollinterval=5*60,
    project='myproj',
    hgbin='C:\Program Files\TortoiseHg\hg.exe'))

Change History (3)

comment:1 Changed 7 years ago by dustin

  • Milestone changed from undecided to 0.8.9
  • Type changed from undecided to defect

This looks like it's a bit harder than just changing a regexp somewhere:

            # fortunately, Mercurial issues all filenames one one line

(I suppose it's "unfortunately" here. At any rate, that's from the hg log invocation. I suspect we'll need to invoke hg once for each revision, then, to get the real list of filenames?

comment:2 Changed 7 years ago by shoelzer

I think you're right about invoking hg once per revision. For each revision you can list changed files one per line using using hg status.

hg status --no-status --change 33

comment:3 Changed 6 years ago by shoelzer

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.