Opened 6 years ago

Closed 6 years ago

#2592 closed enhancement (fixed)

Add interpolation to VS* steps

Reported by: dickymoe Owned by:
Priority: minor Milestone: 0.8.+
Version: 0.8.8 Keywords:
Cc:

Description

It could be interessting to add the interpolation to Visual Step properties.

For example : you want to add a ChoiceStringParameter? to the config (build or rebuild) and use this properties in the "mode" in VS Step. 

factory.addStep(
        visualFunc(
            name="name",
            projectfile=...,
            config=..,
            arch="Win32",
            mode=Interpolate("%(prop:modeName)s"),
            env=...))

Change History (4)

comment:1 Changed 6 years ago by dickymoe

  • Summary changed from Add interpolation to VS* parameters to Add interpolation to VS* steps

comment:2 Changed 6 years ago by dustin

  • Milestone changed from undecided to 0.8.+
  • Priority changed from major to minor

I like it - do you want to try to write a patch to do so? See SubmittingPatches

comment:3 Changed 6 years ago by dickymoe

Made here : ​https://github.com/dickymoe/buildbot/tree/enhancement_%232592

I just append the 'mode' to the list of renderables properties.

comment:4 Changed 6 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

Great - and that's merged! Thanks!

Note: See TracTickets for help on using tickets.