Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#2588 closed undecided (fixed)

Check in upgrade_master that `rotateLength` and `maxRotatedFiles` are valid

Reported by: rutsky Owned by: Jc2k
Priority: blocker Milestone: 0.8.9
Version: 0.8.8 Keywords:
Cc: rutsky.vladimir@…

Description

Recently buildbot create-master created buildbot.tac with invalid default values for rotateLength and maxRotatedFiles variables --- they were strings instead numbers:

rotateLength = '10000000'
maxRotatedFiles = '10'

That led to invalid Twisted log rotating behavior --- Twisted logs doesn't rotated at all.

This bug was fixed in https://github.com/buildbot/buildbot/pull/964 pull request: https://github.com/buildbot/buildbot/commit/0a6063c54565dc7806bedb87d74c419e59805ae0

Such Buildbot error can be fixed on end user Buildbot installations --- buildbot.tac can be checked and fixed during buildbot upgrage_master.

If no one would like to fix this (I'm a bit lazy and not interested in this right now), at least note about this issue should be added to release notes for next Buildbot release.

Change History (4)

comment:1 Changed 5 years ago by Jc2k

  • Owner set to Jc2k
  • Priority changed from major to blocker
  • Status changed from new to assigned

comment:2 Changed 5 years ago by Jc2k

It is difficult to fix the tac file automatically as it contains code and is often heavily customized. It looks like the best we can do right now is warn when we detect the error.

See https://github.com/buildbot/buildbot/pull/1156

comment:3 Changed 5 years ago by Jc2k

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged into buildbot-0.8.9.

comment:4 Changed 5 years ago by Andriy Senkovych <jolly_roger@…>

In d217eda47027ad7407d9bc7afd6d14186fbc2994:

Add more information about buildbot upgrade errors (Refs: #2588)

Note: See TracTickets for help on using tickets.