Ticket #258 (closed defect: fixed)

Opened 5 years ago

Last modified 3 years ago

buildbot -try doesn't work with perforce changesource

Reported by: karlkoehler Owned by:
Priority: major Milestone: 0.8.+
Version: 0.7.7 Keywords:
Cc: karlkoehler

Description

When using perforce, buildbot -try doesn't work. This is due to tryclient.py not including a PerforceExtractor?.

Attachments

p4.diff Download (1.9 KB) - added by karlkoehler 5 years ago.
patch to implement try-compile for p4.

Change History

Changed 5 years ago by karlkoehler

patch to implement try-compile for p4.

comment:1 follow-up: ↓ 3 Changed 5 years ago by karlkoehler

Note about this patch:

The "readPatch" - function has to know how to extract your branches. This means that that regular expression has to agree with the p4base and split_file you put in your master.cfg.

Is there an elegent solution for this ?

comment:2 Changed 4 years ago by dustin

  • Cc karlkoehler added
  • Milestone changed from undecided to 0.7.+

If you can provide some documentation of such, in docs/buildbot.texinfo?

comment:3 in reply to: ↑ 1 Changed 3 years ago by dustin

Replying to karlkoehler:

Is there an elegent solution for this ?

Karl - can you write up the restriction with a little bit more detail, so that I can put it in the documentation? That should be elegant enough..

comment:4 Changed 3 years ago by Kovarththanan Rajaratnam

  • Status changed from new to closed
  • Resolution set to fixed

TryClient?: add Perforce support (fixes #258)

Initial patch by Karl Koehler.

There is still some work to do here. Mostly documentation.

Changeset: 64f18856e348cfeeb2d6823f57df46c5424c71c0

Note: See TracTickets for help on using tickets.