Missing argument for git clean

[Cici]

The 0.8.8 documentation states under GIT/method/fresh:

This remove all other files except those tracked by Git. First it does git clean -d -f -x then fetch/checkout to a specified revision(if any).

However, git clean -d -f -x does not remove all untracked subdirectories (e.g. old git submodules are not removed) as the git clean manpage states:

-d Remove untracked directories in addition to untracked files. If an untracked directory is managed by a different git repository, it is not removed by default. Use -f option twice if you really want to remove such a directory.

So basically you have to use git clean -d -f -f -x.

The same issue occurs for GIT/method/clean.

[dustin]

Thanks! Do you want to cook up a patch and adjust the tests?

[Cici]

Replying to dustin:

Thanks! Do you want to cook up a patch and adjust the tests?

No, I just wanted to report this issue :-)

[dustin]

ewong just committed a fix to this:

​https://github.com/buildbot/buildbot/commit/19473b5ff288b07e13b9b6632e11e998e7903c80