buildbot forced build always uses the default mergerequest function

[brendan]

I've tried setting mergeRequests=False and mergeRequests=lambda a, b, c: False in a BuilderConfig?, but it has no effect at least when I force builds on that builder. I am working around this by setting the project to a random value when I force a build.

I'm running 0.8.5. The closest related ticket I see is #2008, which seems to have been marked fixed for 0.8.5.

[dustin]

Ah, it's a bug in the BuilderConfig stuff. This should fix it:

master/buildbot/config.py

@@ -121 +121 @@
             rv['env'] = self.env
         if self.properties:
             rv['properties'] = self.properties
-        if self.mergeRequests:
+        if self.mergeRequests is not None:
             rv['mergeRequests'] = self.mergeRequests
         return rv

[dustin]

I made that fix in master. However, it doesn't explain the same problem occurring with the lambda. And I can't replicate that with 0.8.5. Can you replicate it, either with or without the patch above?