Opened 5 years ago

Closed 4 years ago

#2555 closed defect (worksforme)

buildbot forced build always uses the default mergerequest function

Reported by: brendan Owned by:
Priority: major Milestone: 0.8.9
Version: 0.8.5 Keywords:
Cc:

Description

I've tried setting mergeRequests=False and mergeRequests=lambda a, b, c: False in a BuilderConfig?, but it has no effect at least when I force builds on that builder. I am working around this by setting the project to a random value when I force a build.

I'm running 0.8.5. The closest related ticket I see is #2008, which seems to have been marked fixed for 0.8.5.

Change History (3)

comment:1 Changed 5 years ago by dustin

Ah, it's a bug in the BuilderConfig stuff. This should fix it:

  • master/buildbot/config.py

    diff --git a/master/buildbot/config.py b/master/buildbot/config.py
    index d9e61fc..b6ec5c7 100644
    a b class BuilderConfig: 
    121121            rv['env'] = self.env
    122122        if self.properties:
    123123            rv['properties'] = self.properties
    124         if self.mergeRequests:
     124        if self.mergeRequests is not None:
    125125            rv['mergeRequests'] = self.mergeRequests
    126126        return rv

comment:2 Changed 5 years ago by dustin

  • Milestone changed from undecided to 0.8.9

I made that fix in master. However, it doesn't explain the same problem occurring with the lambda. And I can't replicate that with 0.8.5. Can you replicate it, either with or without the patch above?

comment:3 Changed 4 years ago by dustin

  • Resolution set to worksforme
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.