Opened 6 years ago

Closed 5 years ago

#2550 closed enhancement (fixed)

GerritStatusPush: fatal: "--verified" is not a valid option

Reported by: cbessette Owned by: sa2ajj
Priority: major Milestone: 0.9.0
Version: 0.8.7p1 Keywords: gerrit
Cc:

Description

As of Gerrit 2.6, "--verified" is no longer an option for gerrit review, even though it exists in the documentation:

http://gerrit-documentation.googlecode.com/svn/Documentation/2.6/cmd-review.html

You now must do "--label Verified=+1" to verify. Even with the Verify label correctly installed and working, "--verified" still doesn't work.

Please update master/buildbot/status/status_gerrit.py to support the label syntax to Verify.

Change History (8)

comment:1 Changed 6 years ago by cbessette

The necessary change:

-command.extend(["--verified %d" % int(verified)])
+command.extend(["--label Verified=%d" % int(verified)])

comment:2 Changed 6 years ago by dustin

Want to make a Github pull req so you can get due credit?

comment:3 Changed 6 years ago by cbessette

Will do!

comment:5 Changed 5 years ago by krf

By the way: it's not entirely correct, that --verified is no longer an option. It's still working as stated in the documentation.

Citing from [1]: "When I say the behavior of --verified hasn't changed, what I mean is if you run it on a server that had a Verified approval category in the DB prior to upgrading to 2.6, which would subsequently have been migrated to All-Projects, --verified will still be valid. But note that for new sites we no longer create the Verified label by default, so maybe that is causing some confusion."

[1] https://code.google.com/p/gerrit/issues/detail?id=1963#c6

comment:6 Changed 5 years ago by dustin

Any chance you could take a look at pull 830 and update it so we can merge it?

comment:7 Changed 5 years ago by sa2ajj

  • Owner set to sa2ajj
  • Status changed from new to assigned

I hope this problem will be solved when https://github.com/buildbot/buildbot/pull/1175 is finalised.

comment:8 Changed 5 years ago by dustin

  • Milestone changed from undecided to 0.9.0
  • Resolution set to fixed
  • Status changed from assigned to closed
  • Type changed from undecided to enhancement

And that just got merged..

Note: See TracTickets for help on using tickets.