Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#2540 closed enhancement (fixed)

Lots of ignored exceptions in buildbot

Reported by: buck Owned by: dustin
Priority: critical Milestone: 0.9.0
Version: 0.8.7p1 Keywords: simple
Cc:

Description

I've been bitten twice by ignored, unlogged exceptions in the "nine" branch preventing buildbot from running correctly.

I did a quick scan and found a bunch of questionable exception handlers.

As a bare minimum, these should log the exception.

http://paste.pound-python.org/show/onIO4YLupocZ8IoOiQW9/

Change History (4)

comment:1 Changed 5 years ago by dustin

  • Keywords simple added
  • Milestone changed from undecided to 0.9.0
  • Priority changed from major to critical
  • Type changed from undecided to enhancement

Bare except's are definitely to be avoided.

It would be great to fix all of these and then enable the corresponding pep8 check, so that we don't re-introduce them.

comment:2 Changed 5 years ago by dustin

  • Owner set to dustin
  • Status changed from new to assigned

comment:3 Changed 5 years ago by Dustin J. Mitchell <dustin@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In ff638cffd7118a65dddfe8349a8ceb9e1399bc7c:

have pylint check for bare except's

Fixes #2540.

comment:4 Changed 5 years ago by Mikhail Sobolev <mss@…>

In 707a35311822caee580f534f429b76035d55f8a1:

Merge pull request #1227 from djmitche/bug2540

Replace bare excepts

Fixes ticket:2540

Note: See TracTickets for help on using tickets.