Opened 4 years ago

Closed 4 years ago

#2536 closed defect (fixed)

GerritStatusPush's reviewCB only passes 4 parameters since 0.8.8

Reported by: krf Owned by:
Priority: major Milestone: 0.8.8
Version: master Keywords: gerrit
Cc:

Description (last modified by dustin)

Just upgraded from 0.8.7 to 0.8.9-pre:

Now I am getting this:

2013-07-29 15:44:44+0200 [-] Exception caught notifying <buildbot.status.status_gerrit.GerritStatusPush instance at 0x3fba710> of buildFinished event
2013-07-29 15:44:44+0200 [-] Unhandled Error
        Traceback (most recent call last):
          File "/home/build/opt/lib/python2.7/site-packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/build.py", line 307, in buildFinished
            w.callback(self)
          File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py", line 368, in callback
            self._startRunCallbacks(result)
          File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py", line 464, in _startRunCallbacks
            self._runCallbacks()
          File "/usr/local/lib/python2.7/dist-packages/twisted/internet/defer.py", line 551, in _runCallbacks
            current.result = callback(current.result, *args, **kw)
        --- <exception caught here> ---
          File "/home/build/opt/lib/python2.7/site-packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/builder.py", line 535, in _buildFinished
            w.buildFinished(name, s, results)
          File "/home/build/opt/lib/python2.7/site-packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/status_gerrit.py", line 96, in buildFinished
            message, verified, reviewed = self.reviewCB(builderName, build, result, self.reviewArg)
        exceptions.TypeError: customGerritReviewCB() takes exactly 5 arguments (4 given)

This commit breaks compatibility for custom GerritStatusPush?'s reviewCB implementations when upgrading from 0.8.7 -> 0.8.8:

commit 70002d7b24f5d32c1a4a3650c3b69e1509e164ba
Author: Jacob Stultz <jstultz@alum.mit.edu>
Date:   Fri Jul 27 17:23:29 2012 -0700

    Add optional start callback to GerritStatusPush

The source-incompatible change:

(...)
+        message, verified, reviewed = self.reviewCB(builderName, build, result, self.reviewArg)
(...)
-                message, verified, reviewed = self.reviewCB(builderName, build, result, self.status, self.reviewArg)

This change is not listed in the release notes, so I'm assuming it is not wanted(?)

Change History (3)

comment:1 Changed 4 years ago by krf

Whoops, sorry for not using WikiFormatting here. I forgot about that.

Can't edit the description either, anymore. Maybe you should fix your Trac setup? :)

comment:2 Changed 4 years ago by dustin

  • Description modified (diff)
  • Keywords gerrit added; regression removed
  • Milestone changed from undecided to 0.8.8
  • Type changed from undecided to defect

comment:3 Changed 4 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in 0.8.8 - Thanks, krf!

Note: See TracTickets for help on using tickets.