Opened 6 years ago

Closed 5 years ago

#2531 closed enhancement (fixed)

Git step fails, if workdir exists but isn't a git checkout.

Reported by: tom.prince Owned by:
Priority: minor Milestone: undecided
Version: master Keywords: git master-side-source-steps
Cc:

Description

If the workdir exists, but isn't a git checkout, buildbot will try to clone to that directory, but will fail, since git clone fails on a non-empty directory.

Change History (3)

comment:1 Changed 6 years ago by srinup

Now git source step has retry option(http://docs.buildbot.net/latest/manual/cfg-buildsteps.html#id3). If git checkout fail because of some reason it will remove the build directory and clone again.

If the directory is created by buildbot I think it should be empty before clone. Can you please tell when(use case) the build directory is not empty before git tries to clone.

comment:2 Changed 6 years ago by dustin

In irc, tomprince suggested that the best we can do here is this: if the builddir exists, but the .git subdirectory does not, then clobber.

That requires adding a ListDir? command on the slave, and checking for its existence on the master, but I think that's a good addition to the protocol anyway.

comment:3 Changed 5 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.