Opened 4 years ago

Closed 4 years ago

#2530 closed defect (fixed)

RSS feed date is non-conformant with RFC822

Reported by: voyta Owned by:
Priority: minor Milestone: undecided
Version: 0.8.7p1 Keywords:
Cc:

Description

Date format provided in RSS feed does not conform to RFC822 required by RSS 2.0 specification (http://feed2.w3.org/docs/rss2.html).

Day-of-week and month are reported as numbers instead of abbreviated names, example:

current: <pubDate>2, 16 7 2013 11:55:33 GMT</pubDate>

correct: <pubDate>Tue, 16 Jul 2013 11:55:33 GMT</pubDate>

This can cause clients expecting the standard format to display the date incorrectly (e.g. Microsoft Outlook 2010).

This bug has been introduced in https://github.com/buildbot/buildbot/commit/4ce04c06ee328f4491d1f51e18b94ae4dd0e12d7

The "fixed-english-locale" arrays introduced in the patch are not used, and only the index is reported.

Suggested fix is changing line 69 (in that broken commit)

res = res % (tstamp.tm_wday, tstamp.tm_mon)

to

res = res % (_abbr_day[tstamp.tm_wday], _abbr_mon[tstamp.tm_mon])

Change History (1)

comment:1 Changed 4 years ago by clepple

  • Resolution set to fixed
  • Status changed from new to closed

The suggested fix works for me. Created a pull request: https://github.com/buildbot/buildbot/pull/806

Note: See TracTickets for help on using tickets.