Opened 5 years ago

Last modified 4 years ago

#2503 new enhancement

Extend the `fileIsImportant` API

Reported by: ludovicchabant Owned by:
Priority: minor Milestone: 0.9.+
Version: 0.8.7p1 Keywords: schedulers


Unless I'm missing something, there's no way right now to tell why a change is not being built in the waterfall view. You see changes in the leftmost column, and some trigger builds, some don't.

It would be nice if the fileIsImportant callbacks could also specify reasons for whether files in a change are important or not, and that would be communicated in the web UI. If it was indeed important, then it would also be nice if we could see the list of builds that were triggered by it.

Change History (5)

comment:1 Changed 5 years ago by dustin

That sounds like a lot of data to keep around - one string per change per scheduler.

It might make sense to log that to the master's twistd.log, though. What do you think?

comment:2 Changed 5 years ago by ludovicchabant

Wouldn't this data be only kept for as long as whatever the horizon settings say they should? Also, I don't think this would actually add any more fields to the log tables... it would merely replace the string that says "Scheduler" as a reason for a build with a longer string: "Scheduler, change #3432 was core code, change #3433 was whatever".

Logging it in the master log would be acceptable, though.

Last edited 5 years ago by ludovicchabant (previous) (diff)

comment:3 Changed 5 years ago by dustin

  • Milestone changed from undecided to 0.8.+

Maybe I'm confused about what you are looking for? The last part of the last comment talks about changing the buildset reason, I think.

It's not so much that it's a lot of data, as it's another DB table, queries against it, and horizons to apply. I'm not convinced that's worth the expense, when master logging is adequate.

comment:4 Changed 4 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

comment:5 Changed 4 years ago by dustin

  • Keywords web removed
Note: See TracTickets for help on using tickets.