Opened 5 years ago

Last modified 4 years ago

#2499 new defect

PBChangeSource doesn't drop changes when no files start with `prefix`

Reported by: Quentin Owned by:
Priority: minor Milestone: 0.9.+
Version: 0.8.7p1 Keywords: docs, simple
Cc:

Description

Before asking on IRC, setting prefix on PBChangeSource was the only way I knew to drop unwanted changes. I'll use ChangeFilter? now, but I'm still reporting what seems to be a bug.

When looking at a change url (eg. /changes/3124) for a commit not in the PBChangeSource prefix, I see the svn commiter, the svn revision, the changed at date, the category (None), and the commit message. I also see the changed files: "no files".

However, the commit still triggers a rebuild, which is confusing given the doc:

If all the filenames in a given Change are removed, the that whole Change will be dropped.

Thanks for buildbot! :)

Change History (2)

comment:1 Changed 5 years ago by dustin

  • Keywords simple added
  • Milestone changed from undecided to 0.8.+
  • Type changed from undecided to defect

Rather than change behavior (because many users use PBChangeSource with no changes), we should alter the docs.

I think that this occurred a while back when we changed things so that a 'buildbot sendchange' without any files would succeed.

comment:2 Changed 4 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.