Opened 5 years ago

Last modified 4 years ago

#2493 new defect

MySQL tables use default database character set

Reported by: andrewjcg Owned by:
Priority: minor Milestone: 0.9.+
Version: master Keywords: database
Cc:

Description

This is another one thats either low-pri or not really a buildbot bug:

Even though buildbot requires utf8, tables created for a MySQL backed use the default character set used by the database they are created in, which causes issues when this is not utf8. This is obviously a very minor issue since its easy to change the default character set or to fix the tables and this only has to be done once when the database tables are first created. However, it'd probably be nice if buildbot would work independently of what the default database character set is.

I'm not sure of a great solution here, but it will probably be similar to http://trac.buildbot.net/ticket/2492. The SQAlchemy Table objects accept a 'mysql_charset' option which, when set to 'utf8', seems to fix the problem. However, there are several places where Table objects are instantiated and its probably undesirable to change all these call sites.

Change History (2)

comment:1 Changed 5 years ago by dustin

  • Milestone changed from undecided to 0.8.+

Well, since we assume utf-8, we don't necessarily need to write a migration script for this. However, we should find a way to test the tables after the fact to ensure the encoding is correct.

comment:2 Changed 4 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.