Opened 7 years ago

Closed 5 years ago

#2486 closed defect (fixed)

Property() is not rendered in {halt,flunk}OnFailure build step arguments

Reported by: seb_kuzminsky Owned by:
Priority: major Milestone: 0.9.+
Version: 0.8.6p1 Keywords: simple
Cc:

Description

The issue was discussed in #buildbot on 2013-04-12 around 19:45 UTC. djmitche came up with this simple workaround. When inserted into master.cfg, it makes my config work:

shell.Configure.renderables.extend(['haltOnFailure', 'flunkOnFailure'])

Change History (5)

comment:1 Changed 7 years ago by dustin

  • Keywords simple added
  • Milestone changed from undecided to 0.8.+
  • Type changed from undecided to defect

comment:3 follow-up: Changed 6 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

comment:4 in reply to: ↑ 3 Changed 5 years ago by prasoon2211

Replying to dustin:

Ticket retargeted after milestone closed

This seems to have been patched. I followed the history of shell.py and found the commit 8477dc42f09a (git show 8477dc42f09a) which fixes this. The bug was reported on 13-Apr-13 and seems to have been fixed a few days later.

Please review it and close it.

comment:5 Changed 5 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

Indeed, fixed by ​https://github.com/buildbot/buildbot/pull/704

Note: See TracTickets for help on using tickets.