Ticket #248 (closed enhancement: wontfix)

Opened 5 years ago

Last modified 3 years ago

allow space in text part of links on /builders page

Reported by: mj Owned by:
Priority: patches-accepted Milestone:
Version: 0.7.6 Keywords:
Cc:

Description

Could it be possible to add the space to the safe characters in the call to urllib.quote for the text part of the links on the page '/builders' ? This would make the list of builders more human-readable if the name of the builder contains spaces. (see attachment)

Attachments

builder.py.patch Download (526 bytes) - added by mj 5 years ago.

Change History

Changed 5 years ago by mj

comment:1 Changed 5 years ago by warner

How about we keep builder names short and non-space-containing, but add a "builder description" field that is used when making those links?

We can use urllib.quote to allow builder names to have arbitrary characters, but we need to make sure we use it consistently everywhere that puts buildernames in URLs.

comment:2 Changed 4 years ago by dustin

  • Milestone changed from undecided to 1.0.0

comment:3 Changed 3 years ago by dustin

  • Status changed from new to closed
  • Resolution set to wontfix

I think we can get away with properly quoting builder names everywhere. Spaces are only the beginning of the pain here.

comment:4 Changed 3 years ago by dustin

  • Milestone 1.0.0 deleted

Milestone 1.0.0 deleted

Note: See TracTickets for help on using tickets.