Opened 6 years ago

Closed 6 years ago

#2465 closed defect (fixed)

"retry" option for checking out sources seems obsolete

Reported by: hwoarang Owned by:
Priority: major Milestone: 0.8.+
Version: 0.8.7p1 Keywords: master-side-source-steps sprint
Cc: srinupiits@…

Description

Hi

The website mentions the "retry" option here http://buildbot.net/buildbot/docs/latest/manual/cfg-buildsteps.html

but looking at the source code, the "retry" option appears to be part of the /steps/source/oldsource.py which, if I understand correctly, should not be used anymore. Could you please update the documentation on the website to mention that this option is a Noop for new sources? Or could you bring it back as I find this option very useful when running multiple builders at the same time where all of them are cloning the same repository?

Change History (4)

comment:1 Changed 6 years ago by dustin

  • Keywords master-side-source-steps sprint added
  • Milestone changed from undecided to 0.8.+
  • Type changed from undecided to defect

It's present for git and repo, but missing for svn (#2357), bzr, cvs, and mercurial.

comment:2 Changed 6 years ago by hwoarang

Are you sure that this is supposed to work in Git? I have retry=(60, 10) and whenever git fetch/clone fails, I see no retries.

I see that steps/source/base.py accepts a retry= option, but this option is never used in steps/source/git.py. Do I miss something?

comment:3 Changed 6 years ago by dustin

I'm thinking of retryFetch, but you're right - that's not the same.

comment:4 Changed 6 years ago by srinup

  • Cc srinupiits@… added
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.