Opened 6 years ago

Last modified 4 years ago

#2464 new enhancement

gitpoller dying

Reported by: virgilg Owned by:
Priority: major Milestone: 0.9.+
Version: 0.8.7p1 Keywords: simple, sprint
Cc:

Description (last modified by dustin)

After a buildmaster restart (buildmaster 0.8.7p1 on OS X 10.8.2) we're getting the following traceback:

2013-03-05 15:02:14-0800 [-] /System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/utils.py:25: exceptions.DeprecationWarning: Argument strings and environment keys/values passed to reactor.spawnProcess should be str, not unicode.
2013-03-05 15:02:14-0800 [-] gitpoller: processing 0 changes: [] from "https://gitrepo.domain.com/Project/branch"
2013-03-05 15:02:14-0800 [-] while polling for changes
        Traceback (most recent call last):
          File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 368, in callback
            self._startRunCallbacks(result)
          File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 464, in _startRunCallbacks
            self._runCallbacks()
          File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 551, in _runCallbacks
            current.result = callback(current.result, *args, **kw)
          File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 1101, in gotResult
            _inlineCallbacks(r, g, deferred)
        --- <exception caught here> ---
          File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 1043, in _inlineCallbacks
            result = result.throwExceptionIntoGenerator(g)
          File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/python/failure.py", line 382, in throwExceptionIntoGenerator
            return g.throw(self.type, self.value, self.tb)
          File "/Library/Python/2.7/site-packages/buildbot-0.8.7p1-py2.7.egg/buildbot/changes/gitpoller.py", line 109, in poll
            [self.repourl] + refspecs, path=self.workdir)
          File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 551, in _runCallbacks
            current.result = callback(current.result, *args, **kw)
          File "/Library/Python/2.7/site-packages/buildbot-0.8.7p1-py2.7.egg/buildbot/changes/gitpoller.py", line 238, in _convert_nonzero_to_failure
            % (code, stderr))
        exceptions.EnvironmentError: command failed with exit code 128: fatal: https://gitrepo.domain.com/Project/branch/info/refs not found: did you run git update-server-info on the server?

The work directory looks fine.

~/buildmaster/gitpoller_work/Project-Branch-Version$ ls -al
total 16
drwxr-xr-x  7 buildbot  staff  238 Mar  5 18:22 .
drwxr-xr-x  8 buildbot  staff  272 Feb 28 14:31 ..
-rw-r--r--  1 buildbot  staff    0 Mar  5 18:22 FETCH_HEAD
-rw-r--r--  1 buildbot  staff   23 Feb 26 20:27 HEAD
-rw-r--r--  1 buildbot  staff   85 Mar  5 18:22 config
drwxr-xr-x  4 buildbot  staff  136 Feb 26 20:27 objects
drwxr-xr-x  4 buildbot  staff  136 Feb 26 20:27 refs

Change History (7)

comment:1 Changed 6 years ago by dustin

  • Description modified (diff)

comment:2 Changed 6 years ago by dustin

  • Milestone changed from undecided to ongoing
  • Type changed from undecided to support-request

That looks like a git error. *Did* you run git update-server-info on the server?

comment:3 Changed 6 years ago by virgilg

It certainly looks like a git error, but I can't run git update-server-info because I don't control the server. I was more concerned about the traceback - should buildbot try and catch the exception in gitpoller.py or leave it fail like this?

comment:4 Changed 6 years ago by dustin

  • Keywords simple sprint added
  • Milestone changed from ongoing to 0.8.+
  • Type changed from support-request to enhancement

Well, it caught it and reported it to you, basically. Although in this case most of the traceback was unnecessary, in general it's helpful for us Buildbotters to see the whole traceback when something goes awry. It wouldn't be a bad patch to catch EnvironmentError and do something more sensible with it. Otherwise, I'm not so worried about it.

comment:5 follow-up: Changed 6 years ago by dustin

  • Description modified (diff)

Rachel was working on this on the Sunday of the PyCon sprints, but I haven't heard anything since. I don't have any contact info for her. So I'm assuming this is open and available for others to work on at this point.

comment:6 Changed 4 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

comment:7 in reply to: ↑ 5 Changed 4 years ago by prasoon2211

Replying to dustin:

Rachel was working on this on the Sunday of the PyCon sprints, but I haven't heard anything since. I don't have any contact info for her. So I'm assuming this is open and available for others to work on at this point.

Hi. This looked like an easy first bug. So, I made a PR: https://github.com/buildbot/buildbot/pull/1578

Please let me know if this is okay.

Note: See TracTickets for help on using tickets.