Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2450 closed undecided (fixed)

traceback in status_push

Reported by: virgilg Owned by:
Priority: major Milestone: undecided
Version: 0.8.7p1 Keywords:
Cc:

Description

After migrating from 0.8.5 to 0.8.7p1 on OS X 10.8.2, I see the following traceback: 1) at every reconfigure time or 2) at every event status_push

2013-02-15 14:34:48-0800 [-] Unhandled error in Deferred: 2013-02-15 14:34:48-0800 [-] Unhandled Error

Traceback (most recent call last):

File "/Library/Python?/2.7/site-packages/buildbot-0.8.7p1-py2.7.egg/buildbot/status/status_push.py", line 176, in queueNextServerPush

return BlockForEverythingBeingSent?()

File "/System/Library/Frameworks/Python?.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 1187, in unwindGenerator

return _inlineCallbacks(None, gen, Deferred())

File "/System/Library/Frameworks/Python?.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 1045, in _inlineCallbacks

result = g.send(result)

File "/Library/Python?/2.7/site-packages/buildbot-0.8.7p1-py2.7.egg/buildbot/status/status_push.py", line 175, in BlockForEverythingBeingSent?

yield defer.maybeDeferred(self.serverPushCb())

--- <exception caught here> ---

File "/System/Library/Frameworks/Python?.framework/Versions/2.7/Extras/lib/python/twisted/internet/defer.py", line 134, in maybeDeferred

result = f(*args, kw)

exceptions.AttributeError?: Deferred instance has no call method

Change History (4)

comment:1 Changed 7 years ago by Dustin J. Mitchell

  • Resolution set to fixed
  • Status changed from new to closed

Correct deferred handling in status_push.py

Fixes #2450.

Changeset: ea6f4707306feca7c6347697d23c407d25bb26ca

comment:2 Changed 7 years ago by dustin

Simple fix:

  • master/buildbot/status/status_push.py

    a b class StatusPush(StatusReceiverMultiService): 
    172172            # Call right now, we're shutting down.
    173173            @defer.inlineCallbacks
    174174            def BlockForEverythingBeingSent():
    175                 yield defer.maybeDeferred(self.serverPushCb())
     175                yield self.serverPushCb()
    176176            return BlockForEverythingBeingSent()
    177177        else:
    178178            # delay should never be 0.  That can cause Buildbot to spin tightly

comment:3 Changed 7 years ago by virgilg

Excellent! Thank you, Dustin.

comment:4 Changed 7 years ago by Dustin J. Mitchell

Correct deferred handling in status_push.py

Fixes #2450.

Changeset: ea6f4707306feca7c6347697d23c407d25bb26ca

Note: See TracTickets for help on using tickets.