Opened 8 years ago

Closed 7 years ago

#2370 closed enhancement (fixed)

check ShellCommand args against RemoteShellCommand

Reported by: dustin Owned by:
Priority: major Milestone: 0.8.+
Version: 0.8.6p1 Keywords: reconfig, sprint, simple
Cc:

Description (last modified by dustin)

Many of the args to ShellCommand are passed on verbatim to RemoteShellCommand, but this doesn't happen during the configuration load, leading to nasty landmines for users.

For example, ShellCommand(some_unknown_argument=10) will pass a configuration check just fine, but will fail when the step runs.

If possible, we should figure out a way to check these at install time, perhaps just by using inspect to see what args RemoteShellCommand.__init__ takes, and ensuring that the arguments to ShellCommand match that set.

Attachments (1)

ticket2370.patch (2.6 KB) - added by ffledgling 7 years ago.
Rough draft of patch. Requires feedback

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by dustin

  • Keywords sprint simple added

This may be challenging in terms of Python, but requires limited knowledge of Buildbot.

comment:2 Changed 7 years ago by dustin

  • Description modified (diff)

Changed 7 years ago by ffledgling

Rough draft of patch. Requires feedback

comment:3 Changed 7 years ago by dustin

  • Description modified (diff)

This needs a release note, and a minor change to the tests: use assertRaisesConfigError (from buildbot.test.util import config and mix in config.ConfigErrorsMixin). And submit a GitHub? pull request. Other than that, it looks great.

comment:4 Changed 7 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed
commit 6757fe9cecf51bcdfd7b2129a0e4decc6e02e444
Merge: b6bdd89 41cc80c
Author: Dustin J. Mitchell <dustin@mozilla.com>
Date:   Wed Apr 3 19:08:11 2013 -0400

    Merge branch 'ticket2370' of git://github.com/ffledgling/buildbot
Note: See TracTickets for help on using tickets.