Opened 6 years ago

Closed 5 years ago

#2367 closed defect (fixed)

Commit messages limited to 1024 characters

Reported by: sdwilsh Owned by:
Priority: major Milestone: 0.8.+
Version: 0.8.6p1 Keywords: database, sprint
Cc:

Description

The database column for commit messages is limited to 1024 characters (which is rather short, FWIW). If you use the git commit hook provided in contrib, it will happily send a commit message that is longer than this, and buildbot will drop the change on the floor (and luckily log it). Ideally, the commit message column limit would be upgraded, but at the very least, the commit hook should be updated to truncate messages that are too long.

Change History (3)

comment:1 Changed 6 years ago by dustin

  • Milestone changed from undecided to 0.8.+

That's the default, yes, and should probably be changed to use TEXT.

The commit message length *is* checked:

            self.check_length(ch_tbl.c.comments, comments)

although the solution (RuntimeError) is not what you want in this case, I think it beats silently discarding data.

comment:2 Changed 6 years ago by dustin

  • Keywords database sprint added
  • Milestone changed from 0.8.+ to 0.9.+

db changes should be made in nine now. This shouldn't be terribly hard to make.

comment:3 Changed 5 years ago by dustin

  • Milestone changed from 0.9.+ to 0.8.+
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in

commit 358a05518af8cbe30515149cde58052fd84cec29
Author: Andrew Gallagher <agallagher@fb.com>
Date:   Thu May 9 01:47:11 2013 -0700

    Increase the DB lengths for changes.comments and buildset_properties.property_value
    
    The current 1024 char restrictions on these columns occasionally cause issues on a MySQL backend.

in master. This didn't make it into 0.8.8, though.

Note: See TracTickets for help on using tickets.