Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2363 closed defect (fixed)

The workdir property is set to slavebuilddir, not workdir

Reported by: pepsiman Owned by:
Priority: major Milestone: 0.8.+
Version: master Keywords:
Cc:

Description

master/buildbot/process/build.py sets the "workdir" property like this:

            self.setProperty("workdir",
                    self.path_module.join(
                        slavebuilder.slave.slave_basedir,
                        self.builder.config.slavebuilddir),
                    "slave")

This is confusing, as build steps can specify a workdir which is a subdirectory of slavebuilddir.

I'd expect this property to be called "slavebuilddir".

I'd also expect the source of this property to be "Slave", as all other sources start with a capital letter.

Change History (5)

comment:1 Changed 7 years ago by dustin

  • Milestone changed from undecided to 0.8.+
  • Type changed from undecided to defect

Great point. Want to make a patch to change this? We can do so on master, with suitably loud release notes (in case people are using the existing propery).

comment:2 Changed 7 years ago by tom.prince

Well, there is an existing ticket to change slavebuilddir to builddir. Particularly with 0.9.0 which won't have master-side builder directories.

comment:3 Changed 7 years ago by dustin

Yes, I think the property should be named "builddir".

comment:4 Changed 7 years ago by Malcolm Parsons

  • Resolution set to fixed
  • Status changed from new to closed

Rename workdir property to builddir

Fixes #2363

Changeset: 944e1dc9827aeee53622f5e65ade234fec7d7fbe

comment:5 Changed 7 years ago by Malcolm Parsons

Rename workdir property to builddir

Fixes #2363

Changeset: 944e1dc9827aeee53622f5e65ade234fec7d7fbe

Note: See TracTickets for help on using tickets.