Ticket #2336 (closed enhancement: fixed)
Add a method to trigger change pollers early
| Reported by: | Phr33d0m | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.9.+ |
| Version: | 0.8.6p1 | Keywords: | |
| Cc: |
Description
Hello, I've encountered a (probably) unwanted/unexpected situation. I have GitPoller? set to 10 minutes.
- At min 0 gitpoller pulls (it finds no new commits).
- At min 2 a new commit is made.
- At min 3 I do a 'force build' on the IRC bot (i.e. <me> BuildBot: force build MyProject?). It does a git pull, finds the new commit and rebuilds with it.
- At minute 10 gitpoller finds the new commit and starts building again, even if the git commit has been already pulled and the project has already been built with that new commit.
Is there any way to prevent this from happening? I wouldn't want the buildslave to do double work if I decide to see fast results and force a build (through the IRC bot).
Regards.
Change History
comment:1 Changed 10 months ago by dustin
- Summary changed from BuildBot starts building even if it has already done it with 'force build' to Add a method to trigger change pollers early
- Type changed from defect to enhancement
- Milestone changed from undecided to 0.9.+
comment:2 Changed 10 months ago by Phr33d0m
If the master and the slave are on the same system, this can be achieved by setting gitpoller's workdir= to slave's project source/ dir. That way the same directory gets updated and we can avoid double buildings.
If slaves are on other systems I think there's no way of doing it.
comment:3 Changed 10 months ago by tom.prince
This won't work in master, since the gitpoller has been changed to not use the repository to store state.
In any case, this would cause changes to be lost (i.e. not recognized by buildbot) which would confuse some people. For example, the console would be not as useful.
comment:4 Changed 10 months ago by tom.prince
There are now webhooks for triggering pollers early (and somebody was talking about adding support for that to IRC as well).
comment:5 Changed 10 months ago by dustin
- Status changed from new to closed
- Resolution set to fixed
Oh, good point!
https://github.com/buildbot/buildbot/commit/44d9b40f36ed6a2a232a3ffde60b4f0cea519652
So, this is fixed :)
![[Buildbot Logo]](/chrome/site/header-text-transparent.png)
There's no good way to correlate the force with the later change from the poller.
However, it would be nice to have a way to trigger the poller to poll early.