Rebuild via web shows error incorrectly

[Jc2k]

With a recent snapshot of master (and by eye, the faulty code is still there on latest master) pressing the rebuild button works but shows an error message:

rebuilding a build failed (2140L, {'buildername': 2138L}) 

The faulty check is in buildbot/status/web/build.py:

tup = yield bc.rebuildBuild(b, reason, extraProperties)
# check that (bsid, brids) were properly stored
if not (isinstance(tup, tuple) and
        isinstance(tup[0], int) and
        isinstance(tup[1], dict)):
    msg = "rebuilding a build failed "+ str(tup)

It looks like it should work, apart from:

>>> isinstance(2L, int)
False
>>> isinstance(2L, long)
True

However i'm not sure if the db should be leaking long's or if other database backends do return int so opted to file a bug rather than sending a pull request.

[Dustin J. Mitchell]

Don't test types too carefully (long is not an int)

This code really just needs to know whether there was an error. Fixes #2329.

Changeset: 673145e83fefb001c9dcc6579e5e2f962b4b43be

[Dustin J. Mitchell]

Don't test types too carefully (long is not an int)

This code really just needs to know whether there was an error. Fixes #2329.

Changeset: 673145e83fefb001c9dcc6579e5e2f962b4b43be