Error in Triggerable scheduler when codebase is empty.

[verm]

I hit  this error when using the Triggerable scheduler in master:

            if not ss_repository:
                config.error("The codebases argument is not set but still receiving " +
                             "non empty codebase values")

The setup I'm using is rather simple:

1. Download source using RCS.
2. Create tarball
3. Upload tarball to master
4. Trigger builders (updateSourceStamp=True)

• ERROR

5. Download tarball
6. ...

codebases is not set, all source arrives from the same repository.

If I comment this check everything works as expected.

[dustin]

Ugh, and I get a different error (before the code ever gets to your error) when forcing a triggering build:

          File "/Users/dustin/code/buildbot/t/buildbot/master/buildbot/steps/trigger.py", line 155, in start
            ss_for_trigger = self.prepareSourcestampListForTrigger()
          File "/Users/dustin/code/buildbot/t/buildbot/master/buildbot/steps/trigger.py", line 128, in prepareSourcestampListForTrigger
            if codebase in got:

[dustin]

OK, when I do replicate the error, I get ss = {'codebase': , 'project': , 'branch': u, 'repository': , 'hasPatch': False, 'changes': [], 'revision': u}

[dustin]

OK, I think that error is 100% bogus. It may, in fact, be the contrapositive of what was intended. But I'll just delete it.

[Dustin J. Mitchell]

Don't fail triggering if there's no got_revision.

Refs #2328.

Changeset: d7bc842c63372cb455a2914329b9210fd000b148

[Dustin J. Mitchell]

Remove bogus check

At the very least, the check's condition is wrong. I think that the text is wrong, and the comment is confusing, too.

Fixes #2328.

Changeset: c84a4e908248cc98353c87470af113a42097a27b

[Dustin J. Mitchell]

Don't fail triggering if there's no got_revision.

Refs #2328.

Changeset: d7bc842c63372cb455a2914329b9210fd000b148

[Dustin J. Mitchell]

Remove bogus check

At the very least, the check's condition is wrong. I think that the text is wrong, and the comment is confusing, too.

Fixes #2328.

Changeset: c84a4e908248cc98353c87470af113a42097a27b