Opened 6 years ago

Last modified 4 years ago

#2321 assigned enhancement

P4Source: support client syntax

Reported by: sanxiyn Owned by: bdbaddog
Priority: patches-accepted Milestone: 0.9.+
Version: 0.8.6p1 Keywords: p4
Cc: bdbaddog

Description

Perforce path can be specified in "client syntax". Currently P4Source's p4base argument seems to expect "depot syntax".

Right now, p4base argument is used for two different things: as an argument to "p4 changes", and to filter output of "p4 describe". The first can be in any syntax, but the second must be in depot syntax since that's what Perforce outputs. So if one specifies p4base in client syntax, no output matches and no change is added. I think two should be specified by two separate arguments, probably with a sensible default.

Change History (5)

comment:1 Changed 6 years ago by tom.prince

  • Cc bdbaddog added
  • Priority changed from major to minor

comment:2 Changed 6 years ago by dustin

  • Milestone changed from undecided to 0.8.+

comment:3 Changed 5 years ago by tom.prince

  • Owner set to bdbaddog
  • Priority changed from minor to patches-accepted
  • Status changed from new to assigned

This should be handled in the new master-side P4 step, if appropriate, otherwise closed.

comment:4 Changed 5 years ago by bdbaddog

This actually should be handled in the P4Source and not the P4 step. This is equivalent to specifying the URL to SVN, just that P4 is way more flexible in it's equivalent. I'll try to take a look at the code sometime soon.

comment:5 Changed 4 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.