Ticket #2304 (closed defect: fixed)

Opened 12 months ago

Last modified 12 months ago

Code from CVS branches can't be checked out

Reported by: daviddev Owned by:
Priority: critical Milestone: undecided
Version: 0.8.6p1 Keywords: cvs
Cc:

Description

It's not possible to check out code from a specific branch using a CVS repository. For example, using a configuration like this: 

...
c['schedulers'].append(timed.Nightly(name='my_scheduler', 
                builderNames=['builder'],
                branch='MY_BRANCH',
                hour=0,
                minute=0))
...
bFactory.addStep(CVS(mode='full', method='clobber', cvsroot=my_cvsroot, cvsmodule='my_module'))
...

you can see the following call in the logs: 

argv: ['cvs', '-d', 'my_cvsroot', '-z3', 'checkout', '-d', 'build', 'my_module']

I have a fix for it. I will push it asap.

Change History

comment:1 Changed 12 months ago by dustin

please submit a fix for the master-side steps. also. note thst those chamged ober the weekend, so get an up-to-date master.

comment:2 Changed 12 months ago by dustin

sorry, i see the pull req now :)

comment:3 Changed 12 months ago by David Alfonso

  • Status changed from new to closed
  • Resolution set to fixed

Fixes #2304 (self.branch was always empty)

Changeset: cd3ffbf731bd94e81ebf374fe8720d5573ef59e2

comment:4 Changed 12 months ago by Dustin J. Mitchell

Merge branch 'cvsfixes' of  git://github.com/davidag/buildbot

  • 'cvsfixes' of  git://github.com/davidag/buildbot: Added four tests for branches. Two for when the branch is specified on the CVS step and two for when the branch comes from a sourcestamp (e.g. using a timed.Nightly with a specific branch). Fixes #2304 (self.branch was always empty) Changeset: 453110799336c89f9f87f806cf9f0f39242a78a1

comment:5 Changed 12 months ago by David Alfonso

Fixes #2304 (self.branch was always empty)

Changeset: cd3ffbf731bd94e81ebf374fe8720d5573ef59e2

comment:6 Changed 12 months ago by Dustin J. Mitchell

Merge branch 'cvsfixes' of  git://github.com/davidag/buildbot

  • 'cvsfixes' of  git://github.com/davidag/buildbot: Added four tests for branches. Two for when the branch is specified on the CVS step and two for when the branch comes from a sourcestamp (e.g. using a timed.Nightly with a specific branch). Fixes #2304 (self.branch was always empty) Changeset: 453110799336c89f9f87f806cf9f0f39242a78a1
Note: See TracTickets for help on using tickets.