Ticket #2302 (closed enhancement: fixed)
Make FakeMaster not be a mock.
| Reported by: | tom.prince | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 0.8.+ |
| Version: | master | Keywords: | tests |
| Cc: |
Description
It is impossible to test the fix for #2284 with a mock for the master object.
Change History
comment:2 Changed 12 months ago by Dustin J. Mitchell
- Status changed from new to closed
- Resolution set to fixed
Make FakeMaster? a full class, not a Mock
This is a compromise between adding the required methods (and other classes) to fakemaster.py, and mocking out the required methods/class in the tests, or using a real method/class where appropriate. Fixes #2302
Changeset: 374e8c7dd9d248d6e596e4a7db8145a5f82459bc
comment:3 Changed 12 months ago by Dustin J. Mitchell
Make FakeMaster? a full class, not a Mock
This is a compromise between adding the required methods (and other classes) to fakemaster.py, and mocking out the required methods/class in the tests, or using a real method/class where appropriate. Fixes #2302
Changeset: 374e8c7dd9d248d6e596e4a7db8145a5f82459bc
Note: See
TracTickets for help on using
tickets.
![[Buildbot Logo]](/chrome/site/header-text-transparent.png)
See https://github.com/buildbot/buildbot/pull/429