Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#2294 closed defect (fixed)

Typos in manual for ForceScheduler Schedule example

Reported by: rrobino Owned by:
Priority: patches-accepted Milestone: 0.8.7
Version: 0.8.6p1 Keywords: forcebuild
Cc:

Description

http://buildbot.net/buildbot/docs/latest/manual/cfg-schedulers.html?highlight=forcebuild

See ForceScheduler? Schedule section

  1. Innocuous typo: 'completly' should be 'completely'
  2. This line is folded but not recommented, so the example says:

property is the name of the parameter

And that causes buildbot master to choke at that point with the error:

error while parsing config file: invalid syntax

Of course this only happens when people copy and paste, and it is fairly easy to spot, but still it ought to be corrected in the documents.

It's already a real pain for people to interrupt their day to figure out how to get their Force Build button back, this just makes it even harder.

Change History (7)

comment:1 Changed 8 years ago by Rick Robino

  • Resolution set to fixed
  • Status changed from new to closed

Corrected typo in ForceScheduler? example. Fixes #2294.

Changeset: 8290ab1db72bf3fb12e1d8e54d5a88cce3d5cdc0

comment:2 Changed 8 years ago by Dustin J. Mitchell

Merge pull request #399 from rrobino/master

Fixes #2294.

Changeset: 75876119607ea6768ca881629be473f4467768b2

comment:3 Changed 8 years ago by Dustin J. Mitchell

Merge branch 'master' of github.com:buildbot/buildbot

comment:4 Changed 8 years ago by Rick Robino

Corrected typo in ForceScheduler? example. Fixes #2294.

Changeset: 8290ab1db72bf3fb12e1d8e54d5a88cce3d5cdc0

comment:5 Changed 8 years ago by Dustin J. Mitchell

Merge pull request #399 from rrobino/master

Fixes #2294.

Changeset: 75876119607ea6768ca881629be473f4467768b2

comment:6 Changed 8 years ago by Dustin J. Mitchell

Merge branch 'master' of github.com:buildbot/buildbot

comment:7 Changed 8 years ago by Dustin J. Mitchell

Merge branch 'master' into nine

  • master: (78 commits) gotAllRevisions now returns an empty dict when the property is not set typo use empty dictionairy if no got_revisions found in transposed gridview filter out builds with more than 1 sourcestamp. Fixed transposed grid in gridview filter out builds with more than 1 sourcestamp Make sure category is properly updated when loading buildstatus from pickle. remove remaining deferredGenerator uses from buildmaster fix now-incorrect warning for an un-upgraded master release notes for multirepo Filter out all builds with more than one sourcestamp Support for multiple sourcestamps in build status Fixes #2214: Add 'codebase' to Source base; add 'descriptionSuffix' to Source and Shell fix pyflakes Corrected typo in ForceScheduler? example. Fixes #2294. Change fakesource according to real SourceStamp? always return new (cloned) objects if absolute sourcestamps have been requested Assign ?? to revision if unknown Add clone method to sourcestamp Include all sourcestamps as list of dicts in the build status dictionary. typo ...

Conflicts:

master/buildbot/schedulers/base.py master/buildbot/test/fake/fakedb.py master/buildbot/test/unit/test_status_mail.py master/docs/release-notes.rst

Changeset: 52f0e0cf2ddc5869e08d5698841b15d843935085

Note: See TracTickets for help on using tickets.