Solaris patch command is not compatible with GNU patch

[adiroiban]

On Solaris, the default patch command is not compatible with the GNU Patch for which Buildbot was designed.

On Solaris users can install the gpatch package which is the GNU patch command.

For system where only buildbot is running users can replace the /bin/patch with gpatch and buildbot works.

Another option is to change Buildbot to use gpatch on Solaris.

I just wanted to know if you think that this is a bug, and if things can be improved, what changed would like you like to see in buildbot.

Thanks!

[dustin]

I don't think Buildbot should automatically try to do anything. But having an option to specify the patch command sounds like a good plan.

[dustin]

adiroiban, do you want to work up a patch or pull request for this?

[adiroiban]

Hi,

Sorry for taking so long to reply.

I will for toward providing a fix for this. I will submit the work over github.

Thanks for the ping.

Adi

[adiroiban]

Hi,

I have created an initial pull request for fixing this ticket.

The request is at:  https://github.com/buildbot/buildbot/pull/474

Is still requires more work but I just want to know if this is the right direction.

Thanks!

[dustin]

The attached pull request needs documentation and tests, and is only for the slave-side command. This should be ported to the master-side source steps as well, and docs/tests added.