Ticket #2284 (closed defect: fixed)

Opened 14 months ago

Last modified 9 months ago

BuildMaster instance has no attribute 'statusTargets'

Reported by: stepchen Owned by:
Priority: major Milestone: 0.8.7
Version: 0.8.6p1 Keywords:
Cc:

Description

File "/usr/local/lib/python2.6/dist-packages/buildbot-0.8.6p1-py2.6.egg/buildbot/buildslave.py", line 606, in _mail_missing_message

for st in buildmaster.statusTargets:

exceptions.AttributeError?: BuildMaster? instance has no attribute 'statusTargets'

This is the only occurrence of statusTargets in master's source. Changing the field to just 'status' seem to have worked around the problem

Change History

comment:1 Changed 14 months ago by dustin

  • Milestone changed from undecided to 0.8.7

i think that fix is correct but I will need to check.

comment:2 Changed 13 months ago by toto

For refrence:

code snipet:


def _mail_missing_message(self, subject, text):

# first, see if we have a MailNotifier? we can use. This gives us a # fromaddr and a relayhost. buildmaster = self.botmaster.master for st in buildmaster.statusTargets:

if isinstance(st, MailNotifier?):

break

else:

# if not, they get a default MailNotifier?, which always uses SMTP # to localhost and uses a dummy fromaddr of "buildbot". log.msg("buildslave-missing msg using default MailNotifier?") st = MailNotifier?("buildbot")

# now construct the mail

m = Message() m.set_payload(text) mDate? = formatdate(localtime=True) mSubject? = subject mFrom? = st.fromaddr recipients = self.notify_on_missing mTo? = ", ".join(recipients) d = st.sendMessage(m, recipients) # return the Deferred for testing purposes return d


File "/usr/local/lib/python2.6/dist-packages/buildbot-0.8.6p1-py2.6.egg/buildbot/buildslave.py", line 606, in _mail_missing_message

for st in buildmaster.statusTargets:

exceptions. AttributeError?:  BuildMaster?  teambuilding instance has no attribute 'statusTargets'

This is the only occurrence of statusTargets in master's source. Changing the field to just 'status' seem to have worked around the problem

comment:3 Changed 13 months ago by Tom Prince

  • Status changed from new to closed
  • Resolution set to fixed

Fix BuildSlave._mail_missing_message for b4fb9fbf2243db6d091202f58ced453483fecd29.

Fixes #2284.

Changeset: 0aa6b8d4a7bbb7c19d6e63bd616bae09161f1c34

comment:4 Changed 9 months ago by Tom Prince

Fix BuildSlave._mail_missing_message for b4fb9fbf2243db6d091202f58ced453483fecd29.

Fixes #2284.

Changeset: 679cc45455eb2be2fde0eb83713ee1e2af63d03c

comment:5 Changed 9 months ago by Tom Prince

Fix BuildSlave._mail_missing_message for b4fb9fbf2243db6d091202f58ced453483fecd29.

Fixes #2284.

Changeset: 679cc45455eb2be2fde0eb83713ee1e2af63d03c

comment:6 Changed 9 months ago by Tom Prince

Fix BuildSlave._mail_missing_message for b4fb9fbf2243db6d091202f58ced453483fecd29.

Fixes #2284.

Changeset: 679cc45455eb2be2fde0eb83713ee1e2af63d03c

Note: See TracTickets for help on using tickets.