Opened 6 years ago

Last modified 4 years ago

#2282 new enhancement

Bzr hook does not fill in repository information

Reported by: gracinet Owned by:
Priority: patches-accepted Milestone: 0.9.+
Version: 0.8.6p1 Keywords: bzr
Cc:

Description

The Mercurial hook sends repository info all along, which can prove useful, e.g., in multi-repository setups to filter through a doStepIf function.

The Bzr hook does not.

Of course the caveat is that the only possible repository information available to the hook is the path on the local FS where it runs. Still, this would be useful.

Change History (7)

comment:1 Changed 6 years ago by gracinet

To illustrate (on current github master branch),

With the bzr hook:

Category 	None
Changed by 	gracinet
Changed at 	Sun 15 Apr 2012 17:42:12
Branch 	bzr1
Revision 	2

With the Mercurial hook:

Category 	None
Changed by 	gracinet
Changed at 	Sun 15 Apr 2012 17:34:09
Repository 	buildbot/repos/merc1
Branch 	default
Revision 	b36b035a01920e4bd10f13a617a2a7b27928befe

comment:2 Changed 6 years ago by dustin

  • Keywords hook removed
  • Milestone changed from undecided to 0.8.7
  • Type changed from undecided to enhancement

This could easily be changed to provide that information with a configurable value, so that it could have a form that's useful remotely.

comment:3 Changed 6 years ago by gracinet

Absolutely, something more useable remotely would be welcome.

That being said, I tend to use buildbot on big bunches of repositories, which means that anything purely manual would be a pain. On the other hands, these are actually mirrors of reference repositories, which means I can organize them in big sections and filter on that.

For now, I have local changes that make the bzr hook behave consistently wrt the mercurial hook, giving this:

Category 	None
Changed by 	gracinet
Changed at 	Sun 15 Apr 2012 18:05:52
Repository 	file:///home/gracinet/buildbot/repos/bzr2
Branch 	bzr2
Revision 	5

or that, with a strip option similar to Mercurial's set to 2:

Category 	None
Changed by 	gracinet
Changed at 	Sun 15 Apr 2012 18:07:51
Repository 	file:///home/gracinet/buildbot
Branch 	bzr2
Revision 	6

Submitting a pull request is just a matter of finding my way on github (not really used to it)

comment:4 Changed 6 years ago by dustin

SubmittingPatches should help you out there. Thanks in advance :)

comment:5 Changed 6 years ago by gracinet

Thanks for the pointer, pull request done.

comment:6 Changed 5 years ago by tom.prince

  • Priority changed from minor to patches-accepted

comment:7 Changed 4 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.