Ticket #2279 (closed defect: fixed)

Opened 14 months ago

Last modified 14 months ago

checkconfig returns exit code 1 on success?

Reported by: Jc2k Owned by:
Priority: major Milestone: 0.8.7
Version: 0.8.6p1 Keywords:
Cc:

Description

Our internal meta-ci runs checkconfig on commit to the ci config. Since upgrading to 0.8.6 it fails despite printing out that the Config is good!

Looking at:

 https://github.com/buildbot/buildbot/blob/master/master/buildbot/scripts/checkconfig.py

This returns a shell style true or false - 1 for fail, 0 for success.

Looking at:

 https://github.com/buildbot/buildbot/blob/master/master/buildbot/scripts/runner.py

The logic seems to be the other way around.

Change History

comment:1 Changed 14 months ago by dustin

  • Status changed from new to closed
  • Type changed from undecided to defect
  • Resolution set to fixed
  • Milestone changed from undecided to 0.8.7

This got fixed in the recent scripts refactor: 

commit 4394e81b9919593494f51d95304ac6c84101c7e4
Merge: c265e62 0cdc2a8
Author: Dustin J. Mitchell <dustin@mozilla.com>
Date:   Fri Apr 13 12:00:59 2012 -0500

    Merge branch 'scripts-refactor'
Note: See TracTickets for help on using tickets.