Ticket #2278 (closed defect: fixed)

Opened 13 months ago

Last modified 13 months ago

AttributeError moving from 0.8.3 to 0.8.6p1

Reported by: Jc2k Owned by:
Priority: major Milestone: 0.8.7
Version: 0.8.6p1 Keywords: locks
Cc:

Description 

        Traceback (most recent call last):
          File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 767, in unwindGenerator
            return _deferGenerator(f(*args, **kwargs), Deferred())
          File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 669, in _deferGenerator
            result = g.next()
          File "/var/local/ci/eggs/buildbot-0.8.6p1-py2.6.egg/buildbot/process/botmaster.py", line 156, in reconfigService
            self.reconfigServiceSlaves(new_config))
          File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 767, in unwindGenerator
            return _deferGenerator(f(*args, **kwargs), Deferred())
        --- <exception caught here> ---
          File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 669, in _deferGenerator
            result = g.next()
          File "/var/local/ci/eggs/buildbot-0.8.6p1-py2.6.egg/buildbot/process/botmaster.py", line 226, in reconfigServiceSlaves
            slave.setServiceParent(self)
          File "/usr/lib/python2.6/dist-packages/twisted/application/service.py", line 185, in setServiceParent
            self.parent.addService(self)
          File "/usr/lib/python2.6/dist-packages/twisted/application/service.py", line 305, in addService
            service.startService()
          File "/var/local/ci/eggs/buildbot-0.8.6p1-py2.6.egg/buildbot/buildslave.py", line 180, in startService
            self.updateLocks()
          File "/var/local/ci/eggs/buildbot-0.8.6p1-py2.6.egg/buildbot/buildslave.py", line 130, in updateLocks
            lock = self.botmaster.getLockByID(access.lockid)
        exceptions.AttributeError: 'NoneType' object has no attribute 'getLockByID'

Switching to self.parent.getLockByID seemed to get me further.

Change History

comment:3 Changed 13 months ago by dustin

  • Keywords locks added; lock slave removed
  • Type changed from undecided to defect
  • Milestone changed from undecided to 0.8.7

comment:4 Changed 13 months ago by Tom Prince

  • Status changed from new to closed
  • Resolution set to fixed

Set AbstractBuildSlave?.botmaster in setServiceParent rather than aftwards.

setServiceParent calls startService which assumes botmaster is already set.

Fixes #2278.

Changeset: 41d97de528c2d455805609e99d1a73bb588e3b96

comment:5 Changed 13 months ago by Tom Prince

Set AbstractBuildSlave?.botmaster in setServiceParent rather than aftwards.

setServiceParent calls startService which assumes botmaster is already set.

Fixes #2278.

Changeset: 41d97de528c2d455805609e99d1a73bb588e3b96

Note: See TracTickets for help on using tickets.