Ticket #2270 (closed defect: fixed)

Opened 14 months ago

Last modified 8 months ago

Exception found: finished time is None

Reported by: jaredgrubb Owned by:
Priority: minor Milestone: 0.8.7
Version: 0.8.6p1 Keywords:
Cc:

Description 

2012-04-02 15:40:06-0700 [HTTPChannel,100,17.153.51.205] Unhandled Error 
    Traceback (most recent call last):
      File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site-packages/twisted/protocols/basic.py", line 564, in dataReceived
        why = self.lineReceived(line)
      File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site-packages/twisted/web/http.py", line 1551, in lineReceived
        self.allContentReceived()
      File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site-packages/twisted/web/http.py", line 1618, in allContentReceived
        req.requestReceived(command, path, version)
      File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site-packages/twisted/web/http.py", line 773, in requestReceived
        self.process()
    --- <exception caught here> ---
      File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site-packages/twisted/web/server.py", line 132, in process
        self.render(resrc)
      File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site-packages/twisted/web/server.py", line 167, in render
        body = resrc.render(self)
      File "/Users/buildbot/ctbot/src/master/buildbot/status/web/feeds.py", line 55, in render
        data = self.content(request)
      File "/Users/buildbot/ctbot/src/master/buildbot/status/web/feeds.py", line 176, in content
        finishedTime = time.gmtime(int(finished))
    exceptions.TypeError: int() argument must be a string or a number, not 'NoneType'

Change History

comment:1 Changed 14 months ago by dustin

  • Type changed from undecided to defect
  • Milestone changed from undecided to 0.8.7

Any chance you could track down the data that would replicate this?

comment:2 Changed 12 months ago by tom.prince

I think this is probably fixed by  https://github.com/tomprince/buildbot/commit/bug2270

comment:3 Changed 12 months ago by dustin

Looks good to me - merge away!

comment:4 Changed 12 months ago by tom.prince

Since it lacks tests, I was going to try to wait until we had some confirmation it actually fixes the bug.

comment:5 Changed 11 months ago by dustin

Let's get this merged now for 0.8.7's sake (with or without tests).

comment:6 Changed 10 months ago by Tom Prince

  • Status changed from new to closed
  • Resolution set to fixed

Make buildbot.status.web.feeds only return finished builds.

Fixes #2270.

Changeset: 20b5f8f8389d72046d0ddcbf608ff3c5d99a443f

comment:8 Changed 10 months ago by Dustin J. Mitchell

Parse the failures_only arg correctly for feeds

Fixes #2270 (again).

Changeset: 1ed7ebbcd72be39de1b34513831402dcff9ef8b2

comment:9 Changed 9 months ago by Dustin J. Mitchell

Parse the failures_only arg correctly for feeds

Fixes #2270 (again).

Changeset: 1ed7ebbcd72be39de1b34513831402dcff9ef8b2

comment:10 Changed 8 months ago by Tom Prince

Make buildbot.status.web.feeds only return finished builds.

Fixes #2270.

Changeset: 20b5f8f8389d72046d0ddcbf608ff3c5d99a443f

comment:11 Changed 8 months ago by Dustin J. Mitchell

Parse the failures_only arg correctly for feeds

Fixes #2270 (again).

Changeset: 1ed7ebbcd72be39de1b34513831402dcff9ef8b2

Note: See TracTickets for help on using tickets.