Traceback during sending mail in 0.8.6p1

[dottedmag]

Configuration:

    MailNotifier(fromaddr='autobuild@company.com',
                 sendToInterestedUsers=False,
                 extraRecipients=['mailing-list@company.com'],
                 subject='Build status changed on %(builder)s',
                 mode='change',
                 buildSetSummary=True,
                 relayhost='relay.host.company.com'),

Traceback:

2012-03-30_13:16:18.61062 	Traceback (most recent call last):
2012-03-30_13:16:18.61063 	  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 545, in _runCallbacks
2012-03-30_13:16:18.61063 	    current.result = callback(current.result, *args, **kw)
2012-03-30_13:16:18.61064 	  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 796, in _cbDeferred
2012-03-30_13:16:18.61065 	    self.callback(self.resultList)
2012-03-30_13:16:18.61065 	  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 362, in callback
2012-03-30_13:16:18.61066 	    self._startRunCallbacks(result)
2012-03-30_13:16:18.61066 	  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 458, in _startRunCallbacks
2012-03-30_13:16:18.61067 	    self._runCallbacks()
2012-03-30_13:16:18.61067 	--- <exception caught here> ---
2012-03-30_13:16:18.61068 	  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 545, in _runCallbacks
2012-03-30_13:16:18.61068 	    current.result = callback(current.result, *args, **kw)
2012-03-30_13:16:18.61069 	  File "/usr/lib/python2.7/dist-packages/buildbot/status/mail.py", line 448, in _gotBuilds
2012-03-30_13:16:18.61070 	    buildset['results'])
2012-03-30_13:16:18.61070 	  File "/usr/lib/python2.7/dist-packages/buildbot/status/mail.py", line 644, in buildMessage
2012-03-30_13:16:18.61072 	    results, builds, patches, logs)
2012-03-30_13:16:18.61073 	  File "/usr/lib/python2.7/dist-packages/buildbot/status/mail.py", line 543, in createEmail
2012-03-30_13:16:18.61074 	    type = msgdict['type']
2012-03-30_13:16:18.61075 	exceptions.KeyError: 'type'

[dustin]

(fixed by tomprince:)

Don't try to send email, if there are no interesting builds.

Fixes #2236.

Changeset: 71cde798e611d8690f8e0a1c59e42da7f91bffdc