MailNotifier gives exception: 'NoneType' object has no attribute 'changes'

[jaredgrubb]

I see this exception in my logs: 14046 2012-03-21 20:12:14-0700 [-] Starting factory <twisted.mail.smtp.ESMTPSenderFactory instance at 0x102c41a70> 14047 2012-03-21 20:12:14-0700 [-] Exception caught notifying <buildbot.status.mail.MailNotifier? instance at 0x1038bdb00> of buildFinished event 14048 2012-03-21 20:12:14-0700 [-] Unhandled Error 14049 Traceback (most recent call last): 14050 File "/Users/buildbot/ctbot/src/master/buildbot/status/build.py", line 285, in buildFinished 14051 w.callback(self) 14052 File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site-packages/twisted/internet/defer.py", line 368, in callback 14053 self._startRunCallbacks(result) 14054 File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site-packages/twisted/internet/defer.py", line 464, in _startRunCallbacks 14055 self._runCallbacks() 14056 File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site-packages/twisted/internet/defer.py", line 551, in _runCallbacks 14057 current.result = callback(current.result, *args, kw) 14058 --- <exception caught here> --- 14059 File "/Users/buildbot/ctbot/src/master/buildbot/status/builder.py", line 512, in _buildFinished 14060 w.buildFinished(name, s, results) 14061 File "/Users/buildbot/ctbot/src/master/buildbot/status/mail.py", line 435, in buildFinished 14062 return self.buildMessage(name, [build], results) 14063 File "/Users/buildbot/ctbot/src/master/buildbot/status/mail.py", line 654, in buildMessage 14064 d = self.useUsers(build) 14065 File "/Users/buildbot/ctbot/src/master/buildbot/status/mail.py", line 673, in useUsers 14066 d = self.parent.db.changes.getChangeUids(change.number) 14067 exceptions.AttributeError?: 'NoneType?' object has no attribute 'changes' 14068

Sometimes when I see this exception, I get an email; but not always. How does this boject end up without a 'db'?

[jaredgrubb]

Redoing with better formatting:

14046 2012-03-21 20:12:14-0700 [-] Starting factory <twisted.mail.smtp.ESMTPSenderFactory instance at 0x102c41a70>
14047 2012-03-21 20:12:14-0700 [-] Exception caught notifying <buildbot.status.mail.MailNotifier instance at 0x1038bdb00> of buildFinished event
14048 2012-03-21 20:12:14-0700 [-] Unhandled Error
14049     Traceback (most recent call last):
14050       File "/Users/buildbot/ctbot/src/master/buildbot/status/build.py", line 285, in buildFinished
14051         w.callback(self)
14052       File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site-packages/twisted/internet/defer.py", line 368, in callback
14053         self._startRunCallbacks(result)
14054       File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site-packages/twisted/internet/defer.py", line 464, in _startRunCallbacks
14055         self._runCallbacks()
14056       File "/Users/buildbot/ctbot/sandbox/lib/python2.7/site-packages/twisted/internet/defer.py", line 551, in _runCallbacks
14057         current.result = callback(current.result, *args, **kw)
14058     --- <exception caught here> ---
14059       File "/Users/buildbot/ctbot/src/master/buildbot/status/builder.py", line 512, in _buildFinished
14060         w.buildFinished(name, s, results)
14061       File "/Users/buildbot/ctbot/src/master/buildbot/status/mail.py", line 435, in buildFinished
14062         return self.buildMessage(name, [build], results)
14063       File "/Users/buildbot/ctbot/src/master/buildbot/status/mail.py", line 654, in buildMessage
14064         d = self.useUsers(build)
14065       File "/Users/buildbot/ctbot/src/master/buildbot/status/mail.py", line 673, in useUsers
14066         d = self.parent.db.changes.getChangeUids(change.number)
14067     exceptions.AttributeError: 'NoneType' object has no attribute 'changes'
14068    

[jaredgrubb]

It just occured to me that this might be happening when the build ends with an Exception failure .. Since updating to 0.8.6 , I just realized that I havent seen any emails with the status of "Exception failure".

[dustin]

I'm not sure why this didn't get automatically recorded.

commit 4d3b0318025ca38c148a09e2fec5f2f97f61be57
Author: Tom Prince <tom.prince@ualberta.net>
Date:   Fri Mar 23 19:32:20 2012 -0400

    Fix bogus reference to master_status.db in buildbot.status.mail.
    
    Fixes #2254.