Ticket #2253 (closed defect: fixed)

Opened 14 months ago

Last modified 14 months ago

Deal gracefully with exceptions thrown before a build is fully started.

Reported by: tom.prince Owned by:
Priority: major Milestone: undecided
Version: 0.8.6 Keywords:
Cc:

Description

Traceback from #2252 demonstrating this. 

2012-03-22 14:23:39+1300 [-] Unhandled error in Deferred:
2012-03-22 14:23:39+1300 [-] Unhandled Error
        Traceback (most recent call last):
          File "/usr/local/lib/python2.7/site-packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 396, in _stepDone
            return self.startNextStep()
          File "/usr/local/lib/python2.7/site-packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 387, in startNextStep
            d.addErrback(self.buildException)
          File "/usr/local/lib/python2.7/site-packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 312, in addErrback
            errbackKeywords=kw)
          File "/usr/local/lib/python2.7/site-packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 290, in addCallbacks
            self._runCallbacks()
        --- <exception caught here> ---
          File "/usr/local/lib/python2.7/site-packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/internet/defer.py", line 551, in _runCallbacks
            current.result = callback(current.result, *args, **kw)
          File "/usr/local/lib/python2.7/site-packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 491, in buildException
            self.buildFinished(["build", "exception"], EXCEPTION)
          File "/usr/local/lib/python2.7/site-packages/buildbot-0.8.6-py2.7.egg/buildbot/process/build.py", line 507, in buildFinished
            self.remote.dontNotifyOnDisconnect(self.lostRemote)
          File "/usr/local/lib/python2.7/site-packages/Twisted-12.0.0-py2.7-linux-x86_64.egg/twisted/spread/pb.py", line 306, in dontNotifyOnDisconnect
            self.disconnectCallbacks.remove(callback)
        exceptions.ValueError: list.remove(x): x not in list

Change History

comment:1 Changed 14 months ago by Dustin J. Mitchell

  • Status changed from new to closed
  • Resolution set to fixed

Be somewhat more resilient to buildFinished failures

This isn't perfect, because buildFinished alters a lot of state and the means of cleaning up from a partial execution is not clear. Fixes #2253.

Changeset: 084c17d33fb112c9d4f196b4ea70d70536468d78

comment:2 Changed 14 months ago by Dustin J. Mitchell

Be somewhat more resilient to buildFinished failures

This isn't perfect, because buildFinished alters a lot of state and the means of cleaning up from a partial execution is not clear. Fixes #2253.

Changeset: 084c17d33fb112c9d4f196b4ea70d70536468d78

Note: See TracTickets for help on using tickets.