Ticket #2242 (closed enhancement: fixed)

Opened 15 months ago

Last modified 15 months ago

Include the favicon explicitly in the template

Reported by: Unode Owned by:
Priority: minor Milestone: 0.8.7
Version: 0.8.5 Keywords:
Cc:

Description

Under some conditions the favicon may not be loaded by the browser. Adding it explicitly to the template solves the most common issues.

Attached is a simple patch that does exactly that.

Change History

comment:1 Changed 15 months ago by dustin

I don't see an attachment?

comment:2 Changed 15 months ago by Unode

Akismet is not letting me add the attachment. Keeps complaining it's spam.

comment:3 Changed 15 months ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed

Unode pastebinned it to me: 

! patch
From 0bdc5f305753dc755743bc40e6bd3d0aabddef19 Mon Sep 17 00:00:00 2001
From: Renato Alves <rjalves@igc.gulbenkian.pt>
Date: Tue, 13 Mar 2012 17:50:49 +0000
Subject: [PATCH] Add favicon explicitly on the template, relative to the
 project root

---
 master/buildbot/status/web/templates/layout.html |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/master/buildbot/status/web/templates/layout.html b/master/buildbot/status/web/templates/layout.html
index b70a36e..3c25a93 100644
--- a/master/buildbot/status/web/templates/layout.html
+++ b/master/buildbot/status/web/templates/layout.html
@@ -15,6 +15,7 @@
     <title>{{ pageTitle|e }}</title>
     <link rel="stylesheet" href="{{ stylesheet }}" type="text/css" />
     <link rel="alternate" type="application/rss+xml" title="RSS" href="{{ path_to_root }}rss">
+    <link rel="shortcut icon" href="{{ path_to_root }}favicon.ico">
     {% endblock %}
   </head>
   <body class="interface">
-- 
1.7.5.4

and it's applied.

Last edited 15 months ago by dustin (previous) (diff)
Note: See TracTickets for help on using tickets.