Ticket #2241 (closed defect: fixed)

Opened 15 months ago

Last modified 12 months ago

invalid getSourceStamp call in oldsource.py

Reported by: dustin Owned by:
Priority: major Milestone: 0.8.7
Version: master Keywords:
Cc: hborkhuis

Description

Traceback (most recent call last):
  File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site-packages/twisted/internet/defer.py", line 134, in maybeDeferred
    result = f(*args, **kw)
  File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/buildstep.py", line 505, in startStep
    d.addCallback(self._startStep_2)
  File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site-packages/twisted/internet/defer.py", line 301, in addCallback
    callbackKeywords=kw)
  File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site-packages/twisted/internet/defer.py", line 290, in addCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "/home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site-packages/twisted/internet/defer.py", line 551, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/buildstep.py", line 547, in _startStep_2
    setattr(self, renderable, self.build.render(getattr(self, renderable)))
  File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/properties.py", line 177, in render
    return props.render(value)
  File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/process/properties.py", line 137, in render
    return renderable.getRenderingFor(self)
  File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/steps/source/oldsource.py", line 40, in getRenderingFor
    s = build.getSourceStamp()
exceptions.TypeError: getSourceStamp() takes exactly 2 arguments (1 given)

Change History

comment:1 Changed 15 months ago by Dustin J. Mitchell

hack _ComputeRepositoryURL to use codebase

Refs #2241. This is not an actual "fix", but I believe the next multirepo patch will address this.

Changeset: 07172ee37f21d2a291275067240d68b3ac58e379

comment:2 Changed 12 months ago by Tom Prince

  • Status changed from new to closed
  • Resolution set to fixed

Fix _ComputeRepositoryURL for multirepo support.

Fixes #2241, #2230.

Changeset: 0464a04c48887d03d830ee4579dcaba5eb918734

comment:3 Changed 12 months ago by Tom Prince

Fix _ComputeRepositoryURL for multirepo support.

Fixes #2241, #2230.

Changeset: 0464a04c48887d03d830ee4579dcaba5eb918734

Note: See TracTickets for help on using tickets.