Schedulers should have names and reconfigService methods

[dustin]

Rather than using comparableMixin to try to figure out if schedulers are "the same", Buildbot should use scheduler names. And the schedulers which remain present before and after a reconfig should get reconfigService called to look at any config changes.

[dustin]

We'll need this in nine when schedulers get entries in the 'schedulers' table.

[dustin]

This is fixed already in  https://github.com/buildbot/buildbot/commit/b4fb9fbf2243db6d091202f58ced453483fecd29

[keeper]

Hi Dustin,

This is not fixed already. commit which you linked explicitly says about it:

Schedulers are still stopped and re-started at every reconfiguration;
this may be changed in the future.

This problem is seen in configurations with many triggered builders. Once reconfiguration is done - builder which triggered another build and waits for finish will be aborted.

[dustin]

You're right, that only half-fixed the problem:

+        # find any schedulers that don't know how to reconfig, and, if they
+        # have changed, add them to both removed and added, so that we
+        # run the new version.  While we're at it, find any schedulers whose
+        # fully qualified class name has changed, and consider those a removal
+        # and re-add as well. 

So, schedulers with a reconfigService method won't get removed and re-added, but so far none of the schedulers have such a method.

[dustin]

Thanks for calling me out on that error, by the way!